On 28 March 2012 16:21, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Mar 27, 2012 at 03:46:43PM +0530, Thomas Abraham wrote: >> For s3c64xx and exynos platforms, make the selection of PM_GENERIC_DOMAINS >> depend on the CONFIG_PM. > > What's the underlying issue here? This seems like something the PM core > should be dealing with gracefully... The PM_GENERIC_DOMAINS config option has dependency on CONFIG_PM option. When building with PM disabled, the following errors occur. warning: (PLAT_S3C64XX && CPU_EXYNOS4210) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM) warning: (MACH_EXYNOS5_DT) selects SOC_EXYNOS5250 which has unmet direct dependencies (ARCH_EXYNOS && ARCH_EXYNOS5) warning: (PLAT_S3C64XX && CPU_EXYNOS4210) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM) warning: (MACH_EXYNOS5_DT) selects SOC_EXYNOS5250 which has unmet direct dependencies (ARCH_EXYNOS && ARCH_EXYNOS5) [...] drivers/base/power/domain.c: In function '__pm_genpd_add_device': drivers/base/power/domain.c:1132: error: implicit declaration of function 'genpd_acquire_lock' drivers/base/power/domain.c:1168: error: implicit declaration of function 'genpd_release_lock' drivers/base/power/domain.c: In function 'pm_genpd_add_subdomain': drivers/base/power/domain.c:1298: error: implicit declaration of function 'genpd_sd_counter_inc' drivers/base/power/domain.c: In function 'pm_genpd_remove_subdomain': drivers/base/power/domain.c:1341: error: implicit declaration of function 'genpd_sd_counter_dec' make[3]: *** [drivers/base/power/domain.o] Error 1 Thanks, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html