On 15.03.2012 13:56, Mark Brown wrote: > On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote: > >> Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original >> attempt to solve this issue. However, this required adding explicit >> checks to driver code all over the place (if (type == S3C2400 || >> type == S3c2440_HDMIPHY). > > Another option is to change the type to be a pointer to a struct with > quirk flags in it. Sure, that's possible. However, I don't find it any simpler than using bitmasks. Quite to contrary - I consider it redundant to bring new structure into existence when simple uint does the trick just fine (IMHO, of course). If you consider code to be inherently less readable because of this approach I'll rework it. If it's not a such big deal for you I would prefer to keep it as is. Thanks! -- Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |