> -----Original Message----- > From: Darius Augulis [mailto:augulis.darius@xxxxxxxxx] > Sent: Thursday, March 15, 2012 5:27 PM > To: Jingoo Han > Cc: Thomas Abraham; linux-fbdev@xxxxxxxxxxxxxxx; FlorianSchandinat@xxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; kgene.kim@xxxxxxxxxxx; ben- > linux@xxxxxxxxx; patches@xxxxxxxxxx; Kyungmin Park; JeongHyeon Kim; Heiko Stuebner; Kwangwoo Lee; Mark > Brown; Peter Korsgaard; Maurus Cuelenaere > Subject: Re: [PATCH v2 3/3] ARM: Samsung: Rework platform data of s3c-fb driver > > On Thu, Mar 15, 2012 at 10:10 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > > >> There is single board - mini6410 (or real6410) and it's name doesn't > >> depend on connected LCD size. > >> We know, that this board is available with different sizes of LCD and > >> currently we have in kernel support for both sizes. > >> It might be so, that it's implemented not in perfect way, but it was > >> accepted and at least it's working. > > > > > > I don't think so. > > You argues that the wrong code should not be removed because it was accepted and at least it's working. > > It is just wrong usage, which can just work. > > Moreover, your code will make the problem, when 2~5 windows of FIMD IP are used. > > Could please explain that? How does LCD feature selection for mini6410 > and real6410 break that? > Timing for different sizes of LCD is located in two statically > allocated structures which are used at board init time depending on > kernel param line. > Data from one of these structures is copied to s3c-fb platform data > dynamically by board init code. Why it's a problem? What changes if > platform data isn't rewritten dynamically? > > > So, your code can be removed. > > I don't think so. It does not break anything yet. One who make > changes, should ensure backwards compatibility, at least talking about > functionality and hardware (LCD) support, which was added few months > ago. Remember, we talk about kernel parameters line - now it lets > bootloader to select correct LCD size. After your changes, board with > 7" LCD wont show anything. OK, your code work, although the usage is wrong. Thomas, can you keep backwards compatibility? > > Darius A. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |