On Tuesday 13 March 2012, Kukjin Kim wrote:
> The EXYNOS5250 has two Cortex-A15 cores and there's no
> need to call scu_enable() in platform_smp_prepare_cpus().
>
> Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
Can you explain this patch more? It only seems to make the
code less generic, but there is no indication if calling
the scu_get_core_count() function is actually wrong on
exynos5.
Arnd
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 0f2035a..36c3984 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -166,7 +166,10 @@ void __init smp_init_cpus(void)
> void __iomem *scu_base = scu_base_addr();
> unsigned int i, ncores;
>
> - ncores = scu_base ? scu_get_core_count(scu_base) : 1;
> + if (soc_is_exynos5250())
> + ncores = 2;
> + else
> + ncores = scu_base ? scu_get_core_count(scu_base) : 1;
>
> /* sanity check */
> if (ncores > nr_cpu_ids) {
> @@ -183,8 +186,8 @@ void __init smp_init_cpus(void)
>
> void __init platform_smp_prepare_cpus(unsigned int max_cpus)
> {
> -
> - scu_enable(scu_base_addr());
> + if (!soc_is_exynos5250())
> + scu_enable(scu_base_addr());
>
> /*
> * Write the address of secondary startup into the
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
