On 13 March 2012 15:43, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Sun, Mar 11, 2012 at 1:46 PM, Thomas Abraham > <thomas.abraham@xxxxxxxxxx> wrote: > >> This patch series adds new pinctrl driver for Samsung SoC's. The driver supports >> a gpiolib interface as well since Samsung SoC's have a combined pinmux/pinctrl >> and gpio controller. > > Overall this all looks good to me Thomas! > I will provide detailed review if/when it is more ripe for merge. Thanks linus for having a look. The missing bits in the driver are wakeup interrupt and gpio interrupt support. Without these, it would not be possible to meaningfully demonstrate a fully functional system using the pinctrl and gpiolib driver for Exynos4. Regards, Thomas. > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |