On 13 March 2012 11:35, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote: > On 13 March 2012 08:58, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: >> On Thu, 23 Feb 2012 18:08:07 +0530, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote: >>> Add irq domain support for max8997 interrupts. The reverse mapping method >>> used is linear mapping since the sub-drivers of max8997 such as regulator >>> and charger drivers can use the max8997 irq_domain to get the linux irq >>> number for max8997 interrupts. All uses of irq_base in platform data and >>> max8997 driver private data are removed. >>> >>> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> >>> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> >>> Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> >>> --- >>> arch/arm/mach-exynos/mach-nuri.c | 4 -- >>> arch/arm/mach-exynos/mach-origen.c | 1 - >>> drivers/mfd/max8997-irq.c | 60 ++++++++++++++++++++-------------- >>> drivers/mfd/max8997.c | 1 - >>> include/linux/mfd/max8997-private.h | 4 ++- >>> include/linux/mfd/max8997.h | 1 - >>> 6 files changed, 38 insertions(+), 33 deletions(-) [...] >> >> Hahaha. The max8997_irqs table is kind of overdone when the group and mask values >> can be arithmetically derived from the hwirq number.. > > Yes, I agree. Each group could have maximum of 8 interrupts. Then, > data->hwirq % 8 will be the group number and data->hwirq & 7 would be Typo here. group number = data->hwirq >> 3 and mask = data->hwirq & 7. Thanks, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |