Re: [PATCHv3 1/3] ARM: Exynos: JPEG board definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012-02-09 오전 6:46, Marek Szyprowski 쓴 글:
Hello,

On Thursday, February 09, 2012 1:28 PM Kukjin Kim wrote:

ARM: Exynos: JPEG board definition


[...]


+#define EXYNOS4_PA_JPEG			0x11840000
+
  #define EXYNOS4_PA_G2D			0x12800000

  #define EXYNOS4_PA_I2S0			0x03830000
@@ -164,6 +166,7 @@
  #define S5P_PA_FIMC1			EXYNOS4_PA_FIMC1
  #define S5P_PA_FIMC2			EXYNOS4_PA_FIMC2
  #define S5P_PA_FIMC3			EXYNOS4_PA_FIMC3
+#define S5P_PA_JPEG			EXYNOS4_PA_JPEG

I'm not sure we _really_ need to re-define for JPEG.
Why not just use EXYNOS4_PA_JPEG?

The s5p-jpeg driver can be also used on S5PV210 so this approach seems
to be fine, the patch only lacks definitions for the S5PV210 series.

I mean, if we use still this style, re-definition for physical address and interrupt number, it will break one kernel image with others. Anyway, I will apply this and will sort it out next time.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux