Re: [PATCH v3] ARM: S3C24XX DMA resume regression fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/01/12 22:53, Gusakov Andrey wrote:
s3c2410_dma_suspend suspends channels from 0 to dma_channels.
s3c2410_dma_resume resumes channels in reverse order. So
pointer should be decremented instead of being incremented.

Signed-off-by: Gusakov Andrey<dron0gus@xxxxxxxxx>
Reviewed-by: Heiko Stuebner<heiko@xxxxxxxxx>
---
  arch/arm/plat-s3c24xx/dma.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
index 57abec9..16510d5 100644
--- a/arch/arm/plat-s3c24xx/dma.c
+++ b/arch/arm/plat-s3c24xx/dma.c
@@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
  	struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
  	int channel;

-	for (channel = dma_channels - 1; channel>= 0; cp++, channel--)
+	for (channel = dma_channels - 1; channel>= 0; cp--, channel--)
  		s3c2410_dma_resume_chan(cp);
  }


Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux