Kukjin Kim wrote: > > Heiko Stübner wrote: > > > > Am Freitag, 24. Februar 2012, 13:40:27 schrieb Gusakov Andrey: It's preferred that "ARM: S3C24XX: ..." in title. > > > s3c2410_dma_suspend suspends channels from 0 to dma_channels. > > > s3c2410_dma_resume resumes channels in reverse order. So > > > pointer should be decremented insted of being incremented. ...decremented instead of...? BTW, where is sign? Since it's very important, needs Gusakov's reply or re-sending with his sign. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > > > --- > > > arch/arm/plat-s3c24xx/dma.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c > > > index 57abec9..16510d5 100644 > > > --- a/arch/arm/plat-s3c24xx/dma.c > > > +++ b/arch/arm/plat-s3c24xx/dma.c > > > @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void) > > > struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1; > > > int channel; > > > > > > - for (channel = dma_channels - 1; channel >= 0; cp++, channel--) > > > + for (channel = dma_channels - 1; channel >= 0; cp--, channel--) > > > s3c2410_dma_resume_chan(cp); > > > } > > > > Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> > > > > it's interesting, that this is broken since april 2011, so I guess it's > > time > > to fix it :-) > > Yes, absolutely. Will apply and send this with other fixes before 3.3 > release. > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |