On Thu, Feb 16, 2012 at 2:57 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > From: Boojin Kim <boojin.kim@xxxxxxxxxxx> > > Currently there were two part of DMAC PL330 driver for > support old styled s3c-pl330 which has been merged into > drivers/dma/pl330.c driver. Actually, there is no reason > to separate them now. > > Basically this patch merges arch/arm/common/pl330.c into > drivers/dma/pl330.c driver and removes useless exported > symbol, externed function and so on. > > The newer pl330 driver tested on SMDKV310 and SMDK4212 boards > > Cc: Jassi Brar <jassisinghbrar@xxxxxxxxx> > Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Acked-by: Vinod Koul <vinod.koul@xxxxxxxxx> > Signed-off-by: Boojin Kim <boojin.kim@xxxxxxxxxxx> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > --- > Changes since v2: > - Address comments from Russell King > the 'asm/hardware/pl330.h' is moved to 'drivers/dma/pl330.h' > which is used only in drivers/dma/ > > arch/arm/common/Kconfig | 3 - > arch/arm/common/Makefile | 1 - > arch/arm/common/pl330.c | 1959 --------------------------------- > arch/arm/include/asm/hardware/pl330.h | 217 ---- > drivers/dma/Kconfig | 1 - > drivers/dma/pl330.c | 1892 +++++++++++++++++++++++++++++++- > drivers/dma/pl330.h | 251 +++++ > include/linux/amba/pl330.h | 1 - > 8 files changed, 2142 insertions(+), 2183 deletions(-) > delete mode 100644 arch/arm/common/pl330.c > delete mode 100644 arch/arm/include/asm/hardware/pl330.h > create mode 100644 drivers/dma/pl330.h > I repeat yet again, the drivers/dma/pl330.h is included _only_ by drivers/dma/pl330.c so it'll be better to simply move its content in the c file and reduce file count by 1. > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index b8ec03e..65c5f24 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -1,4 +1,7 @@ > -/* linux/drivers/dma/pl330.c > +/* > + * Copyright (c) 2012 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * Boojin Kim <boojin.kim@xxxxxxxxxxx> > * I object. If simply moving the code around grants you share of authorship, then every person who contributed even a single actual bug fix or feature qualifies too. Javi Merino from ARM Ltd contributed far more important patches to PL330 and he never claimed authorship (though I think, if not me, he would have done the driver just as well or better). -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |