On 01/31/2012 03:50 PM, Andrzej Pietrasiewicz wrote:
> Add JPEG board definition and device register
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> Dear All,
>
> This patch adds board definition code and device registration code
> for JPEG IP found in Exynos4 SoC.
>
> It is exactly the same as the previous patch but with better coding style
> compliance.
>
> arch/arm/mach-exynos/Kconfig | 2 ++
> arch/arm/mach-exynos/clock.c | 5 +++++
> arch/arm/mach-exynos/include/mach/map.h | 3 +++
> arch/arm/mach-exynos/mach-nuri.c | 2 ++
> arch/arm/mach-exynos/mach-universal_c210.c | 2 ++
> arch/arm/plat-s5p/Kconfig | 5 +++++
> arch/arm/plat-samsung/devs.c | 26 ++++++++++++++++++++++++++
> arch/arm/plat-samsung/include/plat/devs.h | 1 +
> 8 files changed, 46 insertions(+), 0 deletions(-)
>
[snip]
>
> +#ifdef CONFIG_S5P_DEV_JPEG
> +static struct resource s5p_jpeg_resource[] = {
> + [0] = {
> + .start = S5P_PA_JPEG,
> + .end = S5P_PA_JPEG + SZ_4K - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = IRQ_JPEG,
> + .end = IRQ_JPEG,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
Should be using DEFINE_RES_MEM and DEFINE_RES_IRQ.
Also, wouldn't be a good idea to split this patch into 2 different
patches for platform-specific and board-specific changes?
--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
