Hi Mark, On Mon, Jan 30, 2012 at 3:10 AM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, Jan 28, 2012 at 10:30:36PM +0530, Shubhrajyoti Datta wrote: > > Please delete irrelevant context from your replies. > >> > + ret = request_irq(irq, s3c64xx_spi_irq, 0, "spi-s3c64xx", sdd); > >> Could we have a threaded irq instead and there are prints and that may get >> executed in interrupt context. > > So, clearly we *could*. However I think that's not going to be as > helpful. These errors are never supposed to happen (and if they do > indicate a fairly serious problem) so the performance impact shouldn't > be our primary concern and if they do happen then my suspicion is that > the timing information will be very important. I expect that knowing > exactly when the error occurred is likely to help diagnose what caused > it by virtue of knowing what other things were going on in the system at > that time. I agree . My only concern was that incase someone wants to add prints in the irq that may be handy. However as you rightly pointed that timing is surely to be more of a concern. Thanks for the explanation. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |