On Sat, Jan 07, 2012 at 08:47:47PM +0900, Kukjin Kim wrote:
> Since the arch/arm/mach-s3c2410/include/mach/system-reset.h has
> been removed by commit f88b8979 ("ARM: restart: remove the now
> empty arch_reset()"), so the inclusion of <mach/system-reset.h>
> should be removed at the plat-s3c24xx/cpu.c file.
>
> The build error happens like following:
> arch/arm/plat-s3c24xx/cpu.c:41: fatal error: mach/system-reset.h: No such file or directory
>
> Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> ---
> Russell,
>
> I think, you missed removing this in your patch.
This rather proves the point that the way Samsung stuff is organized is
just too complicated to be properly understood. Yes, it's getting better
as a result of some of the points I raised, but I feel its still too
opaque for anyone except those who know it intimiately to get to grips
with it properly, and follow how the code is organized through all those
plat-* and mach-* directories.
> If you have patches to send to Linus for this merge window,
> could you please send this together? Or...?
Please put it in the patch system and I'll queue it up. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
