On Tue, Dec 20, 2011 at 09:48:31PM +0900, Kukjin Kim wrote: > This patch introduces common.[ch] which are used only in the > arch/arm/mach-s5pv210/ directory. The common.c file merges > the cpu.c and init.c which are used commonly on S5PCV210/S5PC100 > SoC and the common.h local header file replaces with plat/s5pv210.h > file. Note that the patch system does _not_ deal in any way with replacing patch comments. Comments added against a patch already submitted to the patch system containing an attributation get _added_ to the initial comment. So, it ends up looking like this: ARM: 7248/1: S5PV210: introduce arch/arm/mach-s5pv210/common.[ch This patch introduces common.[ch] which are used only in the arch/arm/mach-s5pv210/ directory. The common.c file merges the cpu.c and init.c which are used commonly on S5PCV210/S5PC100 SoC and the common.h local header file replaces with plat/s5pv210.h file. Comments from Kukjin Kim: Subject: [PATCH 04/12] ARM: S5PV210: introduce arch/arm/mach-s5pv210/common.[ch] This patch introduces common.[ch] which are used only in the arch/arm/mach-s5pv210/ directory. The common.c file merges the cpu.c and init.c which are used commonly on S5PCV210/S5PC100 SoC and the common.h local header file replaces with plat/s5pv210.h file. --- Changes: fixed missing ']' at the end of the subject Cc: Ben Dooks <ben-linux@xxxxxxxxx> Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> which I think you can agree is not good. If you want to _change_ the initial comments, please resubmit the patch entirely. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html