On Tue, 2011-12-13 at 23:33 +0200, Denis Kuzmenko wrote: > On 12/13/2011 11:28 PM, Joe Perches wrote: > > The LEDF_ACTLOW use is dependent on it being #defined > > to 1 when using ^. I think that's unintelligible. > Sorry, can't understand. Can you please clarify last two sentences? s3c2410_gpio_setpin(pd->gpio, (value ? 1 : 0) ^ (pd->flags & S3C24XX_LEDF_ACTLOW)); I think this should be: s3c2410_gpio_setpin(pd->gpio, !!value ^ !!(pd->flags & S3C24XX_LEDF_ACTLOW)); -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html