RE: [PATCH] ARM: exynos4: Fix for stall in case of cpu hotplug or sleep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Amit Daniel Kachhap wrote:
> 
> This patch adds remove_irq in place of disable_irq which is
> correct equivalent function for setup_irq used in
> exynos4_mct_tick_init.
> 
> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@xxxxxxxxxx>
> Tested-by: Inderpal Singh <inderpal.singh@xxxxxxxxxx>
> ---
>  arch/arm/mach-exynos/mct.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/mct.c b/arch/arm/mach-exynos/mct.c
> index 97343df..959f251 100644
> --- a/arch/arm/mach-exynos/mct.c
> +++ b/arch/arm/mach-exynos/mct.c
> @@ -428,9 +428,13 @@ int __cpuinit local_timer_setup(struct
> clock_event_device *evt)
> 
>  void local_timer_stop(struct clock_event_device *evt)
>  {
> +	unsigned int cpu = smp_processor_id();
>  	evt->set_mode(CLOCK_EVT_MODE_UNUSED, evt);
>  	if (mct_int_type == MCT_INT_SPI)
> -		disable_irq(evt->irq);
> +		if (cpu == 0)
> +			remove_irq(evt->irq, &mct_tick0_event_irq);
> +		else
> +			remove_irq(evt->irq, &mct_tick1_event_irq);

Hmm, how about the cpu number is 2 or 3 on Quad-core?
As you know, this should be used for all of EXYNOS SoCs.

>  	else
>  		disable_percpu_irq(IRQ_MCT_LOCALTIMER);
>  }
> --
> 1.7.1


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux