On 12 November 2011 19:49, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Sat, Nov 12, 2011 at 12:22 PM, Thomas Abraham > <thomas.abraham@xxxxxxxxxx> wrote: > >> Another question, not related to the above. The gpio and pinctrl >> drivers would operate on the same physical memory space (pinmux and >> gpio is just a single controller). Both gpio and pinctrl driver would >> do a ioremap of this physical address space. I remember reading that >> ioremap of the same physical memory area twice is not correct. So any >> suggestions on how to handle this. > > Yes, create one single driver in a single file that presents a pinctrl *and* > a gpiolib interface. Put the driver in drivers/pinctrl/pinctrl-foo.c. > That's the most natural design pattern methinks. Trying to artificially > break it apart in two driver files doesn't make sense. Yes, this seems better (and additional work). I will try it out. Meanwhile, I will post a simplistic exynos4 pinctrl driver patch, just to ensure it is headed in the right direction. Thanks, Thomas. > > Linus Walleij > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |