Hi Girish, On Mon, Oct 17 2011, Girish K S wrote: >>> + if (card != NULL && mmc_card_mmc(card) && >> >> != NULL is unnecessary. > > This is required. Let me explain the scenario where i felt it is necessary. I'm not saying that you shouldn't test whether card is NULL -- I'm saying that "if (card && mmc_card_mmc(card) && " would perform this test with fewer characters, and be idiomatic for the kernel. Thanks, - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |