Thomas Abraham wrote: > Sent: Tuesday, October 11, 2011 3:16 AM > To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx; kgene.kim@xxxxxxxxxxx; > vinod.koul@xxxxxxxxx; Jassi Brar; Boojin Kim > Subject: [PATCH v6 02/10] DMA: PL330: Infer transfer direction from > transfer request instead of platform data > > The transfer direction for a channel can be inferred from the transfer > request and the need for specifying transfer direction in platfrom > data > can be eliminated. So the structure definition 'struct dma_pl330_peri' > is no longer required. > > The channel's private data is set to point to a channel id specified > in > the platform data (instead of an instance of type 'struct > dma_pl330_peri'). > The filter function is correspondingly modified to match the channel > id. > > With the 'struct dma_pl330_peri' removed from platform data, the dma > controller transfer capabilities cannot be inferred any more. Hence, > the dma controller capabilities is specified using platform data. > > Cc: Jassi Brar <jassisinghbrar@xxxxxxxxx> > Cc: Boojin Kim <boojin.kim@xxxxxxxxxxx> > Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > Acked-by: Jassi Brar <jassisinghbrar@xxxxxxxxx> > Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx> > --- > drivers/dma/pl330.c | 65 +++++++++++--------------------------- > ------ > include/linux/amba/pl330.h | 13 ++------- > 2 files changed, 19 insertions(+), 59 deletions(-) > Looks good to me. Acked-by: Boojin Kim <boojin.kim@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html