Hi Subash, On 10/10/2011 09:05 AM, Subash Patel wrote: > I forgot to add: > > instead of choosing them through config MACH_**** in arch/arm/mach-exynos4/Kconfig > > Regards, > Subash > > On 10/10/2011 12:20 PM, Subash Patel wrote: >> Hi Sylwester, >> >> In the file arch/arm/plat-s5p/Kconfig, why dont we change the below >> >> config S5P_DEV_FIMC0/1/2/3 >> bool >> help >> Compile in platform device definitions for FIMC controller 0/1/2/3 >> >> as >> >> config S5P_DEV_FIMC0/1/2/3 >> bool >> depends on VIDEO_SAMSUNG_S5P_FIMC >> default y >> help >> Compile in platform device definitions for FIMC controller 0/1/2/3 >> >> I find that every time I need to use FIMC, I need to make some >> un-necessary hacks into Kconfig, even though I choose the menu item >> "Samsung S5P and EXYNOS4 camera host interface driver" I'm all for automating these things, although please note plat-s5p/Kconfig is for all relevant mach-* and the number of available FIMC instances is specific to each mach-*. E.g. s5pv210 has only 3 instances, while on exynos4 there are 4. So each mach-* currently selects S5P_DEV_FIMC?. I agree the current scheme might not be the most optimal. I'm open to any suggestions on this. Regards, -- Sylwester Nawrocki Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |