Re: [PATCH] ARM: EXYNOS4: Remove useless codes on NURI board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 6, 2011 at 3:31 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> MyungJoo Ham wrote:
>>
>> 2011/8/19 Kyungmin Park <kmpark@xxxxxxxxxxxxx>:
>> > Maybe charger manager codes are not merged. it's used for charger
> managers.
>> >
>> > To Mr. Ham,
>> > which patches are missing?
>> >
>> > Thank you,
>> > Kyungmin Park
>>
>> The patch to register Charger-Manager in Nuri is missing in the file.
>> In order to apply that, we will need to modify NTC driver (either
>> update hwmon framework or seperate NTC driver into two parts
>> (platorm-device + hwmon-device) first so that in-kernel modules can
>> read values from NTC.
>>
> If missing some stuff will not be merged in this time, to apply this is
> better to us to remove useless warning message during build and if required,
> we can add it later......
>
> Is ok to you?
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>

That's fine. I'll resubmit it as soon as charger-manager work is cleared.


Cheers!
MyungJoo

>> >
>> > On Fri, Aug 19, 2011 at 10:01 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> wrote:
>> >> The 'nuri_cm_devices' is defined but not used.
>> >>
>> >> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> >> Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
>> >> ---
>> >>  arch/arm/mach-exynos4/mach-nuri.c |    7 -------
>> >>  1 files changed, 0 insertions(+), 7 deletions(-)
>> >>
>> >> diff --git a/arch/arm/mach-exynos4/mach-nuri.c
> b/arch/arm/mach-exynos4/mach-
>> nuri.c
>> >> index 43be71b..65df994 100644
>> >> --- a/arch/arm/mach-exynos4/mach-nuri.c
>> >> +++ b/arch/arm/mach-exynos4/mach-nuri.c
>> >> @@ -1037,13 +1037,6 @@ static struct platform_device
> nuri_max8903_device
>> = {
>> >>        },
>> >>  };
>> >>
>> >> -static struct device *nuri_cm_devices[] = {
>> >> -       &s3c_device_i2c5.dev,
>> >> -       &s3c_device_adc.dev,
>> >> -       NULL, /* Reserved for UART */
>> >> -       NULL,
>> >> -};
>> >> -
>> >>  static void __init nuri_power_init(void)
>> >>  {
>> >>        int gpio;
>> >> --
>> >> 1.7.1
>
>



-- 
MyungJoo Ham, Ph.D.
Mobile Software Platform Lab, DMC Business, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux