On Fri, Sep 30, 2011 at 04:41:36PM +0530, Padmavathi Venna wrote: > +#define CLKDEV_INIT(d, n, c) \ > + { \ > + .dev_id = d, \ > + .con_id = n, \ > + .clk = &c, \ > + }, > + As Heartley says, the trailing , and the end should not be there - it should be with each use of CLKDEV_INIT(). The reasoning is that it makes the use of macros much more conventional and consistent throughout the kernel: struct cl_lookup foo_lookups[] = { CLKDEV_INIT(...), CLKDEV_INIT(...), }; struct cl_lookup bar_lookup = CLKDEV_INIT(...); Could you re-spin with that change please? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html