RE: [PATCH] GPIO: Samsung: fix broken configuration for Exynos4 GPIO banks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Grant Likely wrote:
> 
> On Thu, Sep 22, 2011 at 12:02:39PM +0200, Marek Szyprowski wrote:
> > Commit 1b39d5f2cc introduced new common gpio driver for all Samsung GPIO
> > SoCs. The new driver doesn't work correctly on Samsung Exynos4 SoC. It
> > fails to set configuration for all but external interrupt pins. This
> > patch fixes this issue.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> 
> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
> 
> > ---
> >  drivers/gpio/gpio-samsung.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> > index 36f3675..be13580 100644
> > --- a/drivers/gpio/gpio-samsung.c
> > +++ b/drivers/gpio/gpio-samsung.c
> > @@ -446,6 +446,8 @@ static struct samsung_gpio_cfg s3c24xx_gpiocfg_banka
> = {
> >  static struct samsung_gpio_cfg exynos4_gpio_cfg = {
> >  	.set_pull	= exynos4_gpio_setpull,
> >  	.get_pull	= exynos4_gpio_getpull,
> > +	.set_config	= samsung_gpio_setcfg_4bit,
> > +	.get_config	= samsung_gpio_getcfg_4bit,
> >  };
> >
> >  static struct samsung_gpio_cfg s5p64x0_gpio_cfg_rbank = {
> > --
> > 1.7.1.569.g6f426
> >

Oops :(
You're right, applied.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux