Hi Kukjin,
On Thursday 15 September 2011 10:24 AM, Kukjin Kim wrote:
Tushar Behera wrote:
Hi Fabio,
On Wednesday 14 September 2011 05:06 PM, Fabio Estevam wrote:
On Wed, Sep 14, 2011 at 8:01 AM, Tushar Behera<tushar.behera@xxxxxxxxxx>
wrote:
...
+static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, unsigned int
power)
+{
+ int gpio = EXYNOS4_GPE3(4);
+
+ gpio_request(gpio, "GPE3_4");
+ gpio_direction_output(gpio, power);
You should check for returned errors for these functions.
Ok.
Will this be better?
static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, \
No need '\'
unsigned int power)
{
int ret;
unsigned long flag = power ? GPIOF_OUT_INIT_HIGH : \
Same as above.
GPIOF_OUT_INIT_LOW;
ret = gpio_request_one(EXYNOS4_GPE3(4), flag, "GPE3_4");
if (ret)
printk(KERN_ERR "Could not request gpio for LCD power");
}
How about following?
if (power)
ret = gpio_request_one(EXYNOS4_GPE3(4), GPIOF_OUT_INIT_HIGH, "GPE3_4");
else
ret = gpio_request_one(EXYNOS4_GPE3(4), GPIOF_OUT_INIT_LOW, "GPE3_4");
if (ret)
pr_err("failed to request gpio for LCD power: %d\n", ret);
Thanks, I will update accordingly.
Also I will remove the .refresh value as suggested in the other thread.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim<kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
