Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 14, 2011 at 9:07 AM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote:
...

> Will this be better?
>
> static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, \
>                                        unsigned int power)
> {
>        int ret;
>        unsigned long flag = power ? GPIOF_OUT_INIT_HIGH : \
>                                        GPIOF_OUT_INIT_LOW;
>
>        ret = gpio_request_one(EXYNOS4_GPE3(4), flag, "GPE3_4");
>
>        if (ret)
>                printk(KERN_ERR "Could not request gpio for LCD power");
> }

Looks better. You can use pr_err instead of printk(KERN_ERR .

Regards,

Fabio Estevam
��.n��������+%������w��{.n�����{��Ʀ����)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux