Hi Alan, On 4 September 2011 15:23, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: >> SMDKV310 board does not have pull-up resistors populated for the keypad >> row lines (unlike the smdk boards for the previous Samsung SoC's). So >> the pad pull-up for all keypad row lines should be enabled for >> smdkv310 board. > > So does this change the behaviour of existing boards, and if so isn't it > the SMDKV310 that hould be providing the alternate gpio configuration > function ? Among the boards based on the Exynos4 SoC, only the smdk boards use the keypad controller for connecting the keys on the board. All other boards either use gpio keys or use some other mechanism for keyboard input. So this patch is applicable to only the existing exynos4 soc based smdk boards. A pull-up for all the row lines is the default requirement of the keypad controller. So, in this patch, the default gpio and pad configuration function for keypad controller enables the internal pad pull-up. If a upcoming board based on exynos4 does populate pull-up for row lines on the board of the keypad, this patch would still not break anything. If required, such boards could provide another gpio and pad configuration function that disables the internal pull-up. This patch modifies only the exynos4 keypad gpio/pad configuration setup function. All previous Samsung SoC's are not affected by this patch. Thanks, Thomas. > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |