On Mon, 2011-08-29 at 19:25 +0530, Vinod Koul wrote: > On Thu, 2011-08-25 at 11:13 +0900, Boojin Kim wrote: > > This patch updates following 3 items. > > @@ -69,6 +70,10 @@ struct dma_pl330_chan { > > * NULL if the channel is available to be acquired. > > */ > > void *pl330_chid; > > + > > + /* For D-to-M and M-to-D channels */ > > + int burst_sz; /* the peripheral fifo width */ > > + dma_addr_t fifo_addr; > > }; > Why should you store peripheral address and burst size in channel > structure. You should take these from the API and dma_slave_structure Ignore my comment for burst size, but is valid for peripheral address -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html