On Sun, Aug 21, 2011 at 2:16 PM, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Tue, Aug 09, 2011 at 09:43:32AM +0530, Alim Akhtar wrote: >> Exactly, spi_s3c64xx.c (including Sound driver) can not be used with >> pl080 and pl330 (DMAENGINE drivers) as it is. >> Recently I was trying to use PL080 DMAENGINE driver, and i was ended >> up using some #ifdef in the spi driver. >> something like >> #ifdef CONFIG_PL080 >> sdd->tx_dmac.bus_id = dmatx_res->name; >> sdd->rx_dmac.bus_id = dmarx_res->name; >> #else >> sdd->tx_dmac.bus_id = dmatx_res->start; >> sdd->tx_dmac.bus_id = dmatx_res->start; >> #endif >> >> This is because, Pl080 handle the channel as a char *(name) and pl330 >> expect the channel to be enum (a number). > > The alternative is that you do as the Primecell drivers do (which was > designed from the outset to be independent of the specific dmaengine), > and pass the DMA filter parameters as pointers via platform data. > Thanks Russell for your suggestion and pointer. I will Look into this alternative solution. Regards, Alim -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |