Re: [PATCH] ARM: S3C64XX: Remove un-used code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mr. Kim,

On Fri, Aug 19, 2011 at 10:59 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> Mark Brown wrote:
>>
>> On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote:
>> > On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
>> > <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>> > > On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote:
>> > >> Remove un-used backlight code for SMDK6410 board
>>
>> > > Is the data actually wrong?  If not it'd seem better to finish hooking
>> > > it up properly than to remove it.
>>
>> > No, this code is no longer needed, as we are having a common backlight
>> > infrastructure , which serves the same purpose.
>>
>> Ideally your commit log should make this clear - it looks like you're
>> just deleting unreferenced code.
>
> Yes, I agree with your opinion...It was difficult to know why it is un-used
> code when I applied that.
>
Yes, I will explain more in comments in future!

> OK, I will amend its commit log in my tree to clear.
Thank you!


Thanks and Regards,
Banajit Goswami
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux