Hi Boojin, On 27 July 2011 11:01, Boojin Kim <boojin.kim@xxxxxxxxxxx> wrote: > This patch makes Samsung EXYNOS4 to use DMA PL330 driver > on DMADEVICE. The EXYNOS4 uses DMA generic APIs instead of > SAMSUNG specific S3C-PL330 APIs. > > Signed-off-by: Boojin Kim <boojin.kim@xxxxxxxxxxx> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > --- > arch/arm/mach-exynos4/Kconfig | 2 +- > arch/arm/mach-exynos4/clock.c | 16 ++- > arch/arm/mach-exynos4/dma.c | 299 ++++++++++++++++++++++++++--------------- > 3 files changed, 198 insertions(+), 119 deletions(-) > [...] > diff --git a/arch/arm/mach-exynos4/dma.c b/arch/arm/mach-exynos4/dma.c > index 564bb53..d57d662 100644 [...] > +struct dma_pl330_peri pdma0_peri[28] = { > + { > + .peri_id = (u8)DMACH_PCM0_RX, > + .rqtype = DEVTOMEM, > + }, { The client driver specifies the direction of the transfer (DMA_TO_DEVICE or DMA_FROM_DEVICE) when requesting for a dma channel. So, is the rqtype parameter required in the platform data for the dma driver? Thanks, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html