On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim <boojin.kim@xxxxxxxxxxx> wrote: > This patch modifies to merge the dma control code. > Original s3c64xx spi driver has each dma control code for rx and tx channel. > This patch merges these dma control codes into one. > With this patch, a dma setup function and callback function handle > for both rx and tx channel. This is nothing really to do with underlying DMAENGINE API. And, apparently it actually bloats the driver ? 76 insertions(+), 64 deletions(-) Yet, I am not very against the idea. If you must do it, maybe It would have been better to move it early in the patchset, which would have resulted in a smaller and cleaner "spi/s3c64xx: Add support DMA engine API" -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html