On Thu, Jul 21, 2011 at 07:58:03PM +0530, Jassi Brar wrote: > While that does make sense, it makes mandatory the ritual of calling > DMA_SLAVE_CONFIG mandatory for most of the cases. > And I think the effort to set fifo_addr for peripherals is overrated. You have to do that anyway. You're dealing with DMA engine drivers which you don't know the implementation details of. Think about it for a moment, please. The point of the DMA engine abstraction is to make DMA users independent of the DMA engine actually being used. That means all DMA engine drivers and all DMA engine users have to provide a basic set of information to allow them to interact with each other. Encoding random bits of information into inappropriate places like FIFO addresses into DMA engine platform data just means you might was well stay with your private API, because that driver may never be able to work with another DMA engine implementation. So please, either do the job properly, or don't waste peoples time with a half hearted mess of inappropriate platform data. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |