RE: [PATCH v3 1/6] ARM: EXYNOS4: Increase NR_IRQS for devices with more IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



MyungJoo Ham wrote:
> 
> MAX8997/17042, which are used by Exynos4-NURI, use additional IRQ
> numbers after GPIO's IRQs. The patch creates some room for those
> devices.
> 
> Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  arch/arm/mach-exynos4/include/mach/irqs.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/include/mach/irqs.h b/arch/arm/mach-
> exynos4/include/mach/irqs.h
> index 31f6bed..51b5db5 100644
> --- a/arch/arm/mach-exynos4/include/mach/irqs.h
> +++ b/arch/arm/mach-exynos4/include/mach/irqs.h
> @@ -154,6 +154,6 @@
>  #define IRQ_GPIO_END		(S5P_GPIOINT_BASE + S5P_GPIOINT_COUNT)
> 
>  /* Set the default NR_IRQS */
> -#define NR_IRQS			(IRQ_GPIO_END)
> +#define NR_IRQS			(IRQ_GPIO_END + 64)

I applied but basically, we have to avoid using hard coded value like 64 on
this. The NR_IRQS depends on CPU not board but this change is needed for
supporting some specific board and if you need more interrupt numbers, will
you increase it? It is not good way.

We need to fix this up next time.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux