Mark Brown wrote:
>
> On Thu, Jun 30, 2011 at 11:22:50AM +0300, Vasily Khoruzhick wrote:
> > On Thursday 30 June 2011 10:49:30 MyungJoo Ham wrote:
>
> > > + adc->vdd = regulator_get(dev, "vdd");
> > > + if (IS_ERR(adc->vdd)) {
> > > + dev_err(dev, "operating without regulator \"vdd\" .\n");
> > > + ret = PTR_ERR(adc->vdd);
> > > + goto err_alloc;
> > > + }
> > > +
>
> > NACK. Make it optional, otherwise it breaks s3c24xx.
>
> No, the above code is how the regulator API should be used. The API
> will stub itself out if not in use so unless the s3c24xx platforms are
> using regulators and there's a couple of options in the regulator API
> for handling partially defined hookups of regulators on the board.
>
> If there isn't a separate supply for the regulators on S3C24xx devices
> then I guess the best option is to provide that supply as a dummy
> regulator in the s3c24xx core code.
OK, but it means I can't apply this until adding a dummy regulator for
S3C24XX?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
