On Sat, Jul 16, 2011 at 09:39:31AM +0900, Boojin Kim wrote: > Grant Likely wrote: > > > +void *samsung_dma_get_ops(void) > > > +{ > > > + return (void *)&dmaeng_ops; > > > +} > > > +EXPORT_SYMBOL(samsung_dma_get_ops); > > > > If all that is needed is a reference to the dma ops, then you could > > simply export samsung_dmaeng_ops() without a separate function. > > Grant, Thanks for your comments. I can't understand this comment well. > Do you mean to change function name from 'samsung_dma_get_ops()' to > 'samsung_dmaeng_ops()' ? > Or export 'dmaeng_ops' variable instead of making this > 'samsung_dma_get_ops()' function I mean export dmaeng_ops instead of using a function. You also get some type checking by not casting it into a (void*). -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html