Mark Brown wrote: > > On Wed, Jul 13, 2011 at 05:47:37PM +0900, Kukjin Kim wrote: > > > -static inline bool s3c_dma_has_circular(void) > > +static inline bool dma_has_circular(void) > > { > > return false; > > } > > The namespacing here doesn't look great, this is still a Samsung > specific internal API. > OK, will keep it. > Otherwise this looks good. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html