On Wed, Jul 13, 2011 at 4:52 PM, Giridhar Maruthy <giridhar.maruthy@xxxxxxxxxx> wrote: > Using 256fs or 512fs will result in distortion of 24-bit > audio samples. This is because the lrclk generated is not > proper. Using 384 fs generates proper output. > > Signed-off-by: Giridhar Maruthy <giridhar.maruthy@xxxxxxxxxx> > --- > sound/soc/samsung/smdk_wm8994.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c > index e7c1009..45fbe2b 100644 > --- a/sound/soc/samsung/smdk_wm8994.c > +++ b/sound/soc/samsung/smdk_wm8994.c > @@ -8,6 +8,7 @@ > */ > > #include "../codecs/wm8994.h" > +#include <sound/pcm_params.h> > > /* > * Default CFG switch settings to use this driver: > @@ -44,7 +45,9 @@ static int smdk_hw_params(struct snd_pcm_substream *substream, > int ret; > > /* AIF1CLK should be >=3MHz for optimal performance */ > - if (params_rate(params) == 8000 || params_rate(params) == 11025) > + if (params_format(params) == SNDRV_PCM_FORMAT_S24_LE) > + pll_out = params_rate(params) * 384; > + else if (params_rate(params) == 8000 || params_rate(params) == 11025) > pll_out = params_rate(params) * 512; > else > pll_out = params_rate(params) * 256; It might be a good idea to maintain a matrix of sample rates and sizes tested cleanly. Thanks, Jassi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html