> Two questions here: > > - It looks like a lot of this code can be shared between all the drivers > using the dmaengine API. Is there any reason not to factor it out? > - Should this not be adding a new driver for dmaengine based Samsung > CPUs? The ifdefs are very big. I think that dma code looks very similar to current one, so how about using platform_resource setting for dma type and make some inline functions to cover these differences? We already have platform driver for dma in arch/arm and dev-audio.c. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html