Mark Brown wrote: > Hi Mark, Please refer to my other comment which includes block diagram, it can help our understanding about current Samsung DMA usage. > Two questions here: > > - It looks like a lot of this code can be shared between all the drivers > using the dmaengine API. Is there any reason not to factor it out? Hmm...I'm not sure, but let us think/check your suggestions. Thanks :) > - Should this not be adding a new driver for dmaengine based Samsung > CPUs? The ifdefs are very big. OK, we will try. Grant, I think, Mark's suggestion can support multiple platform... Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html