On Tue, Jun 21, 2011 at 7:43 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jun 21, 2011 at 10:58:43AM +0900, MyungJoo Ham wrote: > >> + ret = regulator_enable(adc->vdd); >> + if (!ret) >> + goto err_ioremap; >> + > > This test looks the wrong way round? regulator_enable() should return 0 > on success but this will treat that as an error. Whoops.. thanks for pointing that out! > >> static int s3c_adc_resume(struct platform_device *pdev) >> { >> struct adc_device *adc = platform_get_drvdata(pdev); >> + int ret; >> >> + ret = regulator_enable(adc->vdd); >> clk_enable(adc->clk); >> enable_irq(adc->irq); >> >> writel(adc->prescale | S3C2410_ADCCON_PRSCEN, >> adc->regs + S3C2410_ADCCON); >> >> - return 0; >> + return ret; > > Seems better to return as soon as we notice the error, no point in > starting anything else up if we don't have power. > Ok. I see. -- MyungJoo Ham (함명주), Ph.D. Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: 82-10-6714-2858 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html