On Tue, Jun 21, 2011 at 2:33 PM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote: > On Tuesday 21 June 2011 07:37 AM, MyungJoo Ham wrote: >> >> Signed-off-by: MyungJoo Ham<myungjoo.ham@xxxxxxxxxxx> >> Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx> >> >> -- >> Changes from v1. Thanks so much for your valuable comments, Mark. >> - Removed unnecessary initialization data >> - Add __initdata where necessary >> - Corrected a regulator name for ADC >> --- >> arch/arm/mach-exynos4/mach-nuri.c | 622 >> ++++++++++++++++++++++++++++++++++++- >> 1 files changed, 621 insertions(+), 1 deletions(-) >> > Will it be possible to move PMIC specific defines to a common file and make > appropriate calls in the board-specific file? > > In that way, we can re-use this PMIC code on some other boards (e.g. > Insignal low-cost board Origen featuring Exynos4210 also features MAX8997). > Yes, we have tried creating PMIC defines at a seperated file in our local repositories (still doing so in those repositories). However, that ended up creating multiple PMIC defines (one PMIC define file for each board); the connections between LDO# and devices are different. > > -- > Tushar Behera > -- MyungJoo Ham (함명주), Ph.D. Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: 82-10-6714-2858 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |