On 20 June 2011 22:25, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: <snip> >> + >> +static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = { >> + OF_DEV_AUXDATA("samsung,s3c-sdhci", EXYNOS4_PA_HSMMC(2), >> + "s3c-sdhci.2", &s3c_hsmmc2_def_platdata), >> + OF_DEV_AUXDATA("samsung,s3c-sdhci", EXYNOS4_PA_HSMMC(0), >> + "s3c-sdhci.0", &s3c_hsmmc0_def_platdata), >> + OF_DEV_AUXDATA("samsung,s5pv210-uart", S5P_PA_UART0, >> + "s5pv210-uart.0", NULL), >> + OF_DEV_AUXDATA("samsung,s5pv210-uart", S5P_PA_UART1, >> + "s5pv210-uart.1", NULL), >> + {}, >> +}; <snip> >> +static void __init exynos4_dt_machine_init(void) >> +{ >> + s3c_sdhci0_set_platdata(&smdkv310_hsmmc0_pdata); >> + s3c_sdhci2_set_platdata(&smdkv310_hsmmc2_pdata); > > Are these two lines still necessary? Yes, but these are temporary. The data from smdkv310_hsmmc0_pdata is copied to s3c_hsmmc2_def_platdata which is then used as platform data. I will remove them in the next version of the patch. Thanks, Thomas. > > Otherwise, the patch looks good to me. > > g. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html