On 06/20/2011 12:09 PM, daeinki wrote: > when someone adds new board file with new SoC, he doesn't need to know > this SoC chip has hclk and sclk_fimd or only sclk_fimd(such as exynos4). > using implicit clock means it should know that this SoC chip has both > clocks(bus clock, sclk_fimd) or only sclk_fimd. AFAICS at least two clock sources are connected to LCD controller on each SoC supported by s3c-fb: a bus and dedicated video reference clock. There is a mux inside the device to switch between them for video reference clock in all but most recent SoCs. The driver is already (will be) aware that the mux control bit disappeared in some IP variant and it must split functionality between two clock sources. > > for example, if any driver needs fimd clock frequency then this driver > should know that this SoC chip is exynos4 or not and has both clock > source(bus clock, soure clock fimd) or not(only source clock fimd) > so I think we shoule see only a clock "lcd" regardless of which clock is > used and if exynos4 then sclk_fimd would be set by machine code. I wouldn't make the driver this dumb. It must already handle relatively large differences across the IPs. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |