CCed Display developers from other Samsung open source team On Sat, Jun 11, 2011 at 9:19 PM, Sylwester Nawrocki <snjw23@xxxxxxxxx> wrote: > Hi Anand, > > On 06/10/2011 10:15 AM, Anand Kumar N wrote: >> This patch series is based on the latest >> git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-next >> >> This was originally submitted by Jonghun Han<jonghun.han@xxxxxxxxxxx> >> http://www.spinics.net/lists/arm-kernel/msg101781.html >> This patchset has been not picked up in the mainline due to the unavailibility >> of cldev lookup. So it is being re-submitted rebased to 3.0.0-rc1 and tested >> over the clkdev patches. > > As far as I can see there is no functional changes in these patches comparing > to the original ones. AFAIR the idea with clkdev was to create clock to device > mapping for each SoC variant and have driver using unified clock names across > SoC variants. There is nothing close to that in your following patches. > > Moreover looking at the S5PC110 datasheet only, the list of possible sclk_fimd > parent clocks is specified as "All possible clock sources". It exactly means: > XXTI, XusbXTI, SCLK_HDMI_27M, SCLK_USBPHY_0, SCLK_USBPHY_1, SCLK_HDMIPHY, > SCLK_M_PLL, SCLK_E_PLL, SCLK_V_PLL. So quite many, whereas you are trying > to forcibly use in the driver SCLK_M_PLL only. As it has been pointed out > setting FIMD clock parent should be moved away to board code/DT/bootloader, > which allows to use the driver in unchanged form in various system > configurations. Let the board designer to make decisions about the clock > configurations. > > -- > Regards, > Sylwester > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |