Hello,
On Friday, June 03, 2011 1:52 PM Thomas Abraham wrote:
> On 3 June 2011 12:34, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote:
> > Added Kconfig entry for setup-usb-phy.c on which EHCI support is
> > dependent on.
> >
> > Following the naming convention of other setup files, we have following
> > renaming.
> > usb-phy.c ==> setup-usb-phy.c
> >
> > Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx>
> > ---
> > arch/arm/mach-exynos4/Kconfig | 6 ++++++
> > arch/arm/mach-exynos4/Makefile | 2 +-
> > .../mach-exynos4/{usb-phy.c => setup-usb-phy.c} | 0
> > 3 files changed, 7 insertions(+), 1 deletions(-)
> > rename arch/arm/mach-exynos4/{usb-phy.c => setup-usb-phy.c} (100%)
> >
> > diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-
> exynos4/Kconfig
> > index b92c1e5..a45a022 100644
> > --- a/arch/arm/mach-exynos4/Kconfig
> > +++ b/arch/arm/mach-exynos4/Kconfig
> > @@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
> > help
> > Common setup code for the camera interfaces.
> >
> > +config EXYNOS4_SETUP_USB_PHY
> > + bool
> > + help
> > + Common setup code for USB PHY controller
> > +
> > # machine support
> >
> > menu "EXYNOS4 Machines"
> > @@ -176,6 +181,7 @@ config MACH_NURI
> > select EXYNOS4_SETUP_I2C3
> > select EXYNOS4_SETUP_I2C5
> > select EXYNOS4_SETUP_SDHCI
> > + select EXYNOS4_SETUP_USB_PHY
> > select SAMSUNG_DEV_PWM
> > help
> > Machine support for Samsung Mobile NURI Board.
> > diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-
> exynos4/Makefile
> > index a9bb94f..60fe5ec 100644
> > --- a/arch/arm/mach-exynos4/Makefile
> > +++ b/arch/arm/mach-exynos4/Makefile
> > @@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD) += setup-keypad.o
> > obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
> > obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
> >
> > -obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
> > +obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY) += setup-usb-phy.o
>
> Since plat-s5p/dev-ehci.c is the only consumer of setup-usb-phy.c,
> could setup-usb-phy.o be made dependent on the S5P_DEV_USB_EHCI config
> option? Any particular reason to create a new EXYNOS4_SETUP_USB_PHY
> config option in this case? Will there be a case where usb phy
> configuration code would be used irrespective of dev-ehci being used?
I suggested this solution to keep the consistence in the style. The other reason
is the fact that USB PHY control functions should be also added to usb hs otg
driver so these function will be used by 2 different devices.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
