Re: [PATCH v2 7/7] ARM: Exynos4: Add clkdev support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 05/27/11 18:53, Kyungmin Park wrote:
On Sat, May 28, 2011 at 12:26 AM, Thomas Abraham<thomas.ab@xxxxxxxxxxx>  wrote:
Add clkdev support for Samsung's Exynos4 platform and fixes the
incorrect clock name for the dw_mmc controller.

Signed-off-by: Thomas Abraham<thomas.ab@xxxxxxxxxxx>
---
  arch/arm/Kconfig                            |    1 +
  arch/arm/mach-exynos4/clock.c               |  178 +++++++++------------------
  arch/arm/mach-exynos4/include/mach/clkdev.h |    7 +
  arch/arm/mach-exynos4/time.c                |    2 +
  4 files changed, 67 insertions(+), 121 deletions(-)
  create mode 100644 arch/arm/mach-exynos4/include/mach/clkdev.h

(snip)

diff --git a/arch/arm/mach-exynos4/include/mach/clkdev.h b/arch/arm/mach-exynos4/include/mach/clkdev.h
new file mode 100644
index 0000000..1247f5e
--- /dev/null
+++ b/arch/arm/mach-exynos4/include/mach/clkdev.h
@@ -0,0 +1,7 @@
+#ifndef __MACH_EXYNOS4_CLKDEV_H__
+#define __MACH_EXYNOS4_CLKDEV_H__
+
+#define __clk_get(clk) ({ 1; })
+#define __clk_put(clk) do { } while (0)
+
+#endif

Looks good to me.

One nitpick
How about to just create the one clkdev.h at plat-samsung with proper
ifdef endif config.
I think don't need to create clkdev.h for each SoCs.

No, basically the "mach/clkdev.h" should be added, please see arch/arm/include/asm/clkdev.h.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux