Hi Marek,
On Mon, May 16, 2011 at 10:27 PM, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
> Hello,
>
> On Monday, May 16, 2011 4:06 PM Thomas Abraham wrote:
>
>> On SMDKV310 board, a card detect gpio pin is available that is directly
>> connected to the io pad of the sdhci controller. Fix incorrect value
>> of cd_type field in platform data for sdhci instance 0 and 2.
>>
>> Signed-off-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
>> ---
>> arch/arm/mach-exynos4/mach-smdkv310.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-
>> exynos4/mach-smdkv310.c
>> index 1526764..f6b1c7e 100644
>> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
>> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
>> @@ -78,7 +78,7 @@ static struct s3c2410_uartcfg smdkv310_uartcfgs[]
>> __initdata = {
>> };
>>
>> static struct s3c_sdhci_platdata smdkv310_hsmmc0_pdata __initdata = {
>> - .cd_type = S3C_SDHCI_CD_GPIO,
>> + .cd_type = S3C_SDHCI_CD_INTERNAL,
>> .ext_cd_gpio = EXYNOS4_GPK0(2),
>> .ext_cd_gpio_invert = 1,
>
> When you are changing the card detection type from GPIO to INTERNAL you should
> also remove 'ext_cd_gpio' and 'ext_cd_gpio_invert' definitions.
Thanks for your comments. I will fix this and submit another patch.
Thomas.
>
>> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
>> @@ -96,7 +96,7 @@ static struct s3c_sdhci_platdata smdkv310_hsmmc1_pdata
>> __initdata = {
>> };
>>
>> static struct s3c_sdhci_platdata smdkv310_hsmmc2_pdata __initdata = {
>> - .cd_type = S3C_SDHCI_CD_GPIO,
>> + .cd_type = S3C_SDHCI_CD_INTERNAL,
>> .ext_cd_gpio = EXYNOS4_GPK2(2),
>> .ext_cd_gpio_invert = 1,
>
> The same as with hsmmc0.
>
>> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
>> --
>
> Best regards
> --
> Marek Szyprowski
> Samsung Poland R&D Center
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
