Re: [PATCH v4 2/3] v4l: Move S5P FIMC driver into Video Capture Devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sylwester,

Thanks for the patch.

On Thursday 21 April 2011 17:21:03 Sylwester Nawrocki wrote:
> s5p-fimc now also implements a camera capture video node so move
> it under the "Video capture devices" Kconfig menu. Also update
> the entry to reflect the driver's coverage of EXYNOS4 SoCs.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/media/video/Kconfig |   19 +++++++++++--------
>  1 files changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
> index 4498b94..4f0ac2d 100644
> --- a/drivers/media/video/Kconfig
> +++ b/drivers/media/video/Kconfig
> @@ -927,6 +927,17 @@ config VIDEO_MX2
>  	  This is a v4l2 driver for the i.MX27 and the i.MX25 Camera Sensor
>  	  Interface
> 
> +config  VIDEO_SAMSUNG_S5P_FIMC
> +	tristate "S5P and EXYNOS4 camera host interface driver"

Should this read "Samsung S5P and EXYNOS4" ? Without the brand name kernel 
config entries are a bit cryptic.

> +	depends on VIDEO_DEV && VIDEO_V4L2 && PLAT_S5P
> +	select VIDEOBUF2_DMA_CONTIG
> +	select V4L2_MEM2MEM_DEV
> +	help
> +	  This is a v4l2 driver for the S5P and EXYNOS4 camera host interface
> +	  and video postprocessor.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called s5p-fimc.
> 
>  #
>  # USB Multimedia device configuration
> @@ -1022,13 +1033,5 @@ config VIDEO_MEM2MEM_TESTDEV
>  	  This is a virtual test device for the memory-to-memory driver
>  	  framework.
> 
> -config  VIDEO_SAMSUNG_S5P_FIMC
> -	tristate "Samsung S5P FIMC (video postprocessor) driver"
> -	depends on VIDEO_DEV && VIDEO_V4L2 && PLAT_S5P
> -	select VIDEOBUF2_DMA_CONTIG
> -	select V4L2_MEM2MEM_DEV
> -	help
> -	  This is a v4l2 driver for the S5P camera interface
> -	  (video postprocessor)
> 
>  endif # V4L_MEM2MEM_DRIVERS

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux