On Mon, Apr 25, 2011 at 12:24 PM, Sangbeom Kim <sbkim73@xxxxxxxxxxx> wrote:
> --- a/arch/arm/plat-samsung/include/plat/audio.h
> +++ b/arch/arm/plat-samsung/include/plat/audio.h
> @@ -36,6 +36,8 @@ struct samsung_i2s {
> Â*/
> Â#define QUIRK_NO_MUXPSR Â Â Â Â Â Â Â Â(1 << 2)
> Â#define QUIRK_NEED_RSTCLR Â Â Â(1 << 3)
> +/* If the PCM block has no internal prescalar or MUX */
> +#define QUIRK_NO_DIV Â Â Â Â Â (1 << 4)
> Â Â Â Â/* Quirks of the I2S controller */
> Â Â Â Âu32 quirks;
I think the I2S and PCM configuration don't share enough.
So maybe a separate 'struct samsung_pcm' is warranted here.
Also, if new SoC PCM blocks are going to _not_ have the divider
may be it's a good idea to make that as 'norm' and having divider
as a 'quirk' ? That way, new code wouldn't have to bother adding
the quirk every time.
-j
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
