Re: [PATCH] ARM: EXYNOS4: IRQ flags for SMSC911X set as HIGH

[Tushar Behera <tushar.behera@xxxxxxxxxx>]

Hi,

I found that there are already some patches submitted for this purpose.

http://www.spinics.net/lists/linux-samsung-soc/msg04371.html
http://www.spinics.net/lists/linux-samsung-soc/msg04372.html

Sorry for the trouble. Please ignore this patch.

Regards,
Tushar

On 24 March 2011 14:50, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote:
>
> There is a mismatch in IRQ flag and irq_polarity settings for
> SMSC911X. This results in a kernel warning.
>
> IRQ flag is set to HIGH to match the irq_polarity.
>
> Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx>
> Signed-off-by: Changhwan Youn <chaos.youn@xxxxxxxxxxx>
> ---
> Âarch/arm/mach-exynos4/mach-smdkc210.c | Â Â2 +-
> Âarch/arm/mach-exynos4/mach-smdkv310.c | Â Â2 +-
> Â2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/mach-smdkc210.c b/arch/arm/mach-exynos4/mach-smdkc210.c
> index 25a2568..5ad5e13 100644
> --- a/arch/arm/mach-exynos4/mach-smdkc210.c
> +++ b/arch/arm/mach-exynos4/mach-smdkc210.c
> @@ -120,7 +120,7 @@ static struct resource smdkc210_smsc911x_resources[] = {
> Â Â Â Â[1] = {
> Â Â Â Â Â Â Â Â.start Â= IRQ_EINT(5),
>        Â.end  Â= IRQ_EINT(5),
> - Â Â Â Â Â Â Â .flags Â= IORESOURCE_IRQ | IRQF_TRIGGER_LOW,
> + Â Â Â Â Â Â Â .flags Â= IORESOURCE_IRQ | IRQF_TRIGGER_HIGH,
> Â Â Â Â},
> Â};
>
> diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c
> index 88e0275..a44529d 100644
> --- a/arch/arm/mach-exynos4/mach-smdkv310.c
> +++ b/arch/arm/mach-exynos4/mach-smdkv310.c
> @@ -122,7 +122,7 @@ static struct resource smdkv310_smsc911x_resources[] = {
> Â Â Â Â[1] = {
> Â Â Â Â Â Â Â Â.start Â= IRQ_EINT(5),
>        Â.end  Â= IRQ_EINT(5),
> - Â Â Â Â Â Â Â .flags Â= IORESOURCE_IRQ | IRQF_TRIGGER_LOW,
> + Â Â Â Â Â Â Â .flags Â= IORESOURCE_IRQ | IRQF_TRIGGER_HIGH,
> Â Â Â Â},
> Â};
>
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html



--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html